Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping: Use plain string functions instead of regex matching #4153

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Skipping: Use plain string functions instead of regex matching #4153

merged 2 commits into from
Jun 10, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 10, 2023 •
edited
Loading

less regex usage, as its one of the most memory intensive parts

grafik

Diff - 4% less memory

grafik

@staabm staabm requested a review from TomasVotruba as a code owner June 10, 2023 08:18
@staabm staabm changed the title Use faster plain string functions instead of regex matching Skipping: Use faster plain string functions instead of regex matching Jun 10, 2023
@staabm staabm changed the title Skipping: Use faster plain string functions instead of regex matching Skipping: Use plain string functions instead of regex matching Jun 10, 2023
@TomasVotruba
Copy link
Member

Neat 😎

@TomasVotruba TomasVotruba merged commit 21a233d into rectorphp:main Jun 10, 2023
@staabm staabm deleted the plain branch June 10, 2023 08:55
@staabm staabm mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @TomasVotruba