Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BetterNodeFinder::findLastInstanceOf() as unused + make resolvePreviousNode() private, as used only locally #4195

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Remove BetterNodeFinder::findLastInstanceOf() as unused + make resolvePreviousNode() private, as used only locally #4195

merged 2 commits into from
Jun 12, 2023

Conversation

TomasVotruba
Copy link
Member

  • remove BetterNodeFinder::findLastInstanceOf() as unused
  • make resolvePreviousNode() private, as used only locally

@TomasVotruba TomasVotruba changed the title tv less last instance Remove BetterNodeFinder::findLastInstanceOf() as unused + make resolvePreviousNode() private, as used only locally Jun 12, 2023
@TomasVotruba TomasVotruba mentioned this pull request Jun 12, 2023
Closed
@TomasVotruba TomasVotruba merged commit 9587bed into main Jun 12, 2023
@TomasVotruba TomasVotruba deleted the tv-less-last-instance branch June 12, 2023 12:02
samsonasik
samsonasik reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about mark as @internal instead of making it private? It has @api which should be public.

@TomasVotruba
Copy link
Member Author

I've refactored the only use in Symfony to local use.
In the end the BetterNodeFinder will be half slim :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @samsonasik