Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StrictArrayParamDimFetchRector on is_* calls #4486

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Fix StrictArrayParamDimFetchRector on is_* calls #4486

merged 6 commits into from
Jul 12, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 12, 2023

rector adds a native array type, which is no correct as the method also accepts a regular string

https://getrector.com/demo/5e9396b2-0a09-4570-875c-e69e32eed1bf

@staabm staabm requested a review from TomasVotruba as a code owner July 12, 2023 07:38
@staabm staabm changed the title StrictArrayParamDimFetchRector failing test Fix StrictArrayParamDimFetchRector on is_* calls Jul 12, 2023
@samsonasik samsonasik merged commit d4a432e into rectorphp:main Jul 12, 2023
@samsonasik
Copy link
Member

Thank you @staabm

@TomasVotruba
Copy link
Member

Thank you @staabm 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @samsonasik @TomasVotruba