Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApplicationFileProcessor] Refactor ApplicationFileProcessor to filter file paths early before run both parallel and non-parallel #4519

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

samsonasik
Copy link
Member

Ref #4513 (comment)

@TomasVotruba @staabm this filter file paths by supported file extensions early before process parallel or non-parallel so file counts will correctly counted, this revert the progress bar tweak on PR:

as the file now counted correctly on parallel.

We may need to centralize the process between parallel and non-parallel file process to avoid copy paste code if there is needed change, but that's will need separate PR :)

…r file paths early before run both parallel and non-parallel
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e77f6d2 into main Jul 15, 2023
@samsonasik samsonasik deleted the refactor-app-file branch July 15, 2023 00:45
@samsonasik
Copy link
Member Author

@TomasVotruba @staabm it works 🎉 , tested in CodeIgniter 4 project:

Before, show 790 files counted

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/rector process --clear-cache
 790/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                                                                                                                                    

After, show 783 files counted which the correct files that filtered by file extensions config.

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/rector process --clear-cache
 783/783 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                     

so the progress bar is also 100% without tweaking finish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant