Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MyCLabs\Enum\Enum::equals calls to comparisons #4532

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Refactor MyCLabs\Enum\Enum::equals calls to comparisons #4532

merged 1 commit into from
Jul 18, 2023

Conversation

rojtjo
Copy link
Contributor

@rojtjo rojtjo commented Jul 17, 2023

When upgrading a codebase that uses the myclabs/php-enum package I noticed that the equals calls were not converted to comparisons. These changes add that functionality.

@rojtjo rojtjo requested a review from TomasVotruba as a code owner July 17, 2023 23:30
@TomasVotruba
Copy link
Member

Thank you for this feature 👏

@TomasVotruba TomasVotruba merged commit 5a9315a into rectorphp:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rojtjo @TomasVotruba