Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] [TypeDeclaration] Reduce resolve ClassReflection on each property on TypedPropertyFromStrictConstructorRector #4536

Merged
merged 4 commits into from
Jul 19, 2023
Merged

[Performance] [TypeDeclaration] Reduce resolve ClassReflection on each property on TypedPropertyFromStrictConstructorRector #4536

merged 4 commits into from
Jul 19, 2023

Conversation

samsonasik
Copy link
Member

Only pull once on first property passed.

@samsonasik
[Performance] [TypeDeclaration] Reduce resolve ClassReflection on eac…
27357ca 
…h property on TypedPropertyFromStrictConstructorRector
@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 19, 2023 04:57
@samsonasik
Copy link
Member Author

Ready to merge 👍

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit d060450 into main Jul 19, 2023
@TomasVotruba TomasVotruba deleted the reduce-class-pu branch July 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @actions-user