Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] [Php74] Reduce ClassReflection lookup from property on PropertyTypeChangeGuard #4545

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 19, 2023 14:00
@samsonasik
Copy link
Member Author

@TomasVotruba new phpstan release 1.10.26 https://github.com/phpstan/phpstan/releases/tag/1.10.26

seems cause error on unit test:

➜  rector-phpunit git:(main) vendor/bin/phpunit tests/Rector/ClassMethod/CreateMockToAnonymousClassRector 
PHPUnit 10.2.6 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.5
Configuration: /Users/samsonasik/www/rector-phpunit/phpunit.xml

E.E                                                                 3 / 3 (100%)

Time: 00:01.379, Memory: 90.50 MB

There were 2 errors:

1) Rector\PHPUnit\Tests\Rector\ClassMethod\CreateMockToAnonymousClassRector\CreateMockToAnonymousClassRectorTest::test with data set #0
TypeError: PHPStan\Node\MethodReturnStatementsNode::__construct(): Argument #6 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in phar:///Users/samsonasik/www/rector-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php on line 563

@samsonasik samsonasik enabled auto-merge (squash) July 20, 2023 07:18
@samsonasik samsonasik merged commit 141a94a into main Jul 20, 2023
@samsonasik samsonasik deleted the reduce-class-re branch July 20, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant