Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip pull property from inner class on CompleteDynamicPropertiesRector #4561

Merged
merged 6 commits into from
Jul 20, 2023
Merged

[CodeQuality] Skip pull property from inner class on CompleteDynamicPropertiesRector #4561

merged 6 commits into from
Jul 20, 2023

Conversation

samsonasik
Copy link
Member

Ref https://getrector.com/demo/bd3c66b6-c097-43ae-ba61-cf330beaf57c

The pull from public inner anonymous class should be skipped.

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 20, 2023 23:25
@samsonasik
Copy link
Member Author

@TomasVotruba it seems due to PHPStan 1.10.26 tweak on PR:

The anonymous check seems needed.

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba let's merge it ;)

@samsonasik samsonasik enabled auto-merge (squash) July 20, 2023 23:53
@samsonasik samsonasik merged commit 1411c04 into main Jul 20, 2023
@samsonasik samsonasik deleted the skip-pull-from-inner-class branch July 20, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik