NameImportingPhpDocNodeVisitor: Cheap checks first #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 21, 2023
| @@ -112,26 +118,13 @@ private function processFqnNameImport( | |||
| return null; | |||
| } | |||
|
|
|||
| $parentNode = $identifierTypeNode->getAttribute(PhpDocAttributeKey::PARENT); | |||
There was a problem hiding this comment.
do this check earlier, as it is fast
staabm
commented
Jul 21, 2023
| $newNode = new IdentifierTypeNode($fullyQualifiedObjectType->getShortName()); | ||
|
|
||
| // should skip because its already used | ||
| if ($this->useNodesToAddCollector->isShortImported($file, $fullyQualifiedObjectType)) { | ||
| if (! $this->useNodesToAddCollector->isImportShortable($file, $fullyQualifiedObjectType)) { | ||
| return null; | ||
| } | ||
|
|
||
| if ($this->shouldImport($newNode, $identifierTypeNode, $fullyQualifiedObjectType)) { |
There was a problem hiding this comment.
the block deleted is identical to the one after the outer IF statement
samsonasik
approved these changes
Jul 21, 2023
|
Thank you @staabm |
|
Thanks Markus 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldSkipNameForFullyQualifiedObjectType shows up in profiles, which means it is slow. lets move it after some very fast checks