Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPStanStaticTypeMapper] Make use of toPhpDocNode() on ObjectTypeMapper #4581

Merged
merged 15 commits into from
Jul 25, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 23, 2023 01:39
@samsonasik
Copy link
Member Author

closing for now, it seems the issue is on FQCNize type

@samsonasik samsonasik closed this Jul 23, 2023
@samsonasik samsonasik deleted the object- branch July 23, 2023 01:56
@samsonasik samsonasik restored the object- branch July 23, 2023 12:24
@samsonasik samsonasik reopened this Jul 23, 2023
@TomasVotruba
Copy link
Member

@samsonasik closing for now, it seems the issue is on FQCNize type

I came to the same conslussion.

@samsonasik
Copy link
Member Author

@TomasVotruba I updated to use TypeTraverser::map() based on @ondrejmirtes suggestion at rectorphp/rector#7959 (comment)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba let's merge it to have faster feedback to test 👍

@samsonasik samsonasik merged commit 7a86df0 into main Jul 25, 2023
@samsonasik samsonasik deleted the object- branch July 25, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants