[BUGFIX] Ensure proper reprint with attributes for finalized classes #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cngJo
force-pushed
the
8080-improve-reprint-of-finalized-classes
branch
from
ec0447d to
de8ebf2
Compare
samsonasik
approved these changes
Jul 23, 2023
|
Thank you @cngJo |
samsonasik
reviewed
Jul 23, 2023
| @@ -0,0 +1,21 @@ | |||
| <?php | |||
|
|
|||
| namespace Rector\Tests\Php82\Rector\Class_\ReadOnlyClassRector\Fixture; | |||
There was a problem hiding this comment.
oh, the namespace need to be changed based on the test namespace, I will change that :)
There was a problem hiding this comment.
ah damit, totally missed that. Thank you for taking care of that.
|
wow that was fast, thank you 🎉 |
|
Thank you @cngJo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a finalized class would be printed on the same line as the attribute above, like this:
for the new provided test case.
Fixes #8080