MyCLabs enum equals + keeping methods #4645
Conversation
|
failing test case need to be updated, FQCN result seems expected |
|
I know that test cases need to be resolved. But I dont know how at this moment. In my opinion they are useless and can be deleted. But I am not author of thoses tests so maybe I dont see the proper use case for them. |
|
I removed that failing tests cases because I think that they were usesless. There is no need to refactor non existing enum constatns to new native cases. If there is use case for them please let me know. I will restore them and properly fix code to pass tests |
|
I cant figure out why this job https://github.com/rectorphp/rector-src/actions/runs/6013250808/job/16310321369?pr=4645 failing when my changes arent relevent to this check. |
|
@K0nias I restarted CI build |
|
CI looks good now 👍 Is this ready to merge or something missing? |
|
From me it is ready to merge |
|
Thank you 👍 |
Unfortunately I'm not sure of purpose of rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/usage_of_constant.php.inc and rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/usage_of_constant.php.inc test cases.
Why it should be possible to refactor non existing constants to native enum when this enum will not have those cases?
Closes rectorphp/rector#8051