[TypeDeclaration] Using native type scope get on ReturnTypeInferer #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Aug 4, 2023
| @@ -1,18 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
this remove leftover fixture with .php suffix instead of .php.inc
samsonasik
commented
Aug 4, 2023
| use Rector\DowngradePhp80\Rector\MethodCall\DowngradeNamedArgumentRector; | ||
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| $rectorConfig->rule(SymmetricArrayDestructuringToListRector::class); |
There was a problem hiding this comment.
SymmetricArrayDestructuringToListRector is removed at PR:
so this test no longer needed.
samsonasik
commented
Aug 4, 2023
| @@ -63,7 +63,6 @@ final class MissingInSetCommand extends Command | |||
| __DIR__ . '/../../vendor/rector/rector-phpunit/rules/CodeQuality' => __DIR__ . '/../../vendor/rector/rector-phpunit/config/sets/phpunit-code-quality.php', | |||
|
|
|||
| // rector-downgrade | |||
| __DIR__ . '/../../vendor/rector/rector-downgrade-php/rules/DowngradePhp71' => __DIR__ . '/../../vendor/rector/rector-downgrade-php/config/set/downgrade-php71.php', | |||
There was a problem hiding this comment.
config/set/downgrade-php71.php no longer exists, so it must be unregistered from MissingInSetCommand
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
This was referenced Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting type
$this->nodeTypeResolver->getType()may read docblock which we mostly don't want, this PR make to use$this->nodeTypeResolver->getNativeType()instead.