[PHPStanStaticTypeMapper] Allow Closure type on ClosureTypeMapper based on PHP versions #4785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on PHP versions
samsonasik
commented
Aug 14, 2023
Comment on lines
-1
to
-23
| <?php | ||
|
|
||
| namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\Fixture; | ||
|
|
||
| final class SkipPropertyAssign | ||
| { | ||
| private $command; | ||
|
|
||
| public function __construct(\Closure $command) | ||
| { | ||
| $this->command = $command; | ||
| } | ||
|
|
||
| public function getCommand() | ||
| { | ||
| if (!$this->command instanceof \Closure) { | ||
| return $this->command; | ||
| } | ||
|
|
||
| $this->command = ($this->command)(); | ||
|
|
||
| return $this->command; | ||
| } |
There was a problem hiding this comment.
@TomasVotruba I removed this test fixture, because for whatever type assigned in __construct(), if it replaced in different method, it will always be new type, which I think very rare use case, eg on symfony:
The ClassPropertyAssignToConstructorPromotionRector don't cover that, as other type when re-assign with other type in other method will have different type as well.
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
Thanks, let's merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.