Make NullToStrictStringFuncCallArgRector run without scope #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-avoid-scope-if-possible-2
branch
from
8d8de86 to
1bf92d4
Compare
TomasVotruba
force-pushed
the
tv-avoid-scope-if-possible-2
branch
from
1bf92d4 to
bdf13cb
Compare
samsonasik
reviewed
Aug 14, 2023
| &$string | ||
| ): string { | ||
| $innerPattern = $match['content']; | ||
| $positionDelimiter = strpos((string) $innerPattern, ''); |
There was a problem hiding this comment.
most ArrayDimFetch without context will go ErrorType, this should be skipped as before
samsonasik
reviewed
Aug 14, 2023
| @@ -477,10 +474,6 @@ private function processNullToStrictStringOnNodePosition( | |||
| return null; | |||
| } | |||
|
|
|||
| if ($this->isAnErrorTypeFromParentScope($argValue, $scope)) { | |||
There was a problem hiding this comment.
this should be reverted, most ArrayDimFetch without context will go ErrorType, and it wil cause huge string cast in legacy code
samsonasik
reviewed
Aug 14, 2023
|
|
||
| use Nette\Utils\Strings; | ||
|
|
||
| final class SkipErrorType |
There was a problem hiding this comment.
This fixture removal need to be reverted, per my comment before, ArrayDimFetch without context got ErrorType, it will make the rule unusable as it change the valid type string already, which mostly correct on regex check usage
|
@TomasVotruba I am reverting at #4793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4730