Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Handle crash parent default empty array/string param on AddParamBasedOnParentClassMethodRector #4833

Merged
merged 18 commits into from
Aug 23, 2023
Merged

[Php80] Handle crash parent default empty array/string param on AddParamBasedOnParentClassMethodRector #4833

merged 18 commits into from
Aug 23, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik changed the title [Php80] Handle crash parent default array param on AddParamBasedOnParentClassMethodRector [Php80] Handle crash parent default empty array/string param on AddParamBasedOnParentClassMethodRector Aug 23, 2023
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @klimslim

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@staabm the int/float handling already covered 525442f

@samsonasik samsonasik mentioned this pull request Aug 23, 2023
Closed
TomasVotruba
TomasVotruba approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for merge when ready 👍

@samsonasik samsonasik merged commit 4b34887 into main Aug 23, 2023
@samsonasik samsonasik deleted the crash-default-array branch August 23, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash and Incorrect behavior of AddParamBasedOnParentClassMethodRector
4 participants
@samsonasik @staabm @TomasVotruba @actions-user