Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Caching] Add VersionResolver::PACKAGE_VERSION to FileHashComputer::compute() so cache cleared on composer update got new version #4904

Merged
merged 1 commit into from
Sep 3, 2023
Merged

[Caching] Add VersionResolver::PACKAGE_VERSION to FileHashComputer::compute() so cache cleared on composer update got new version #4904

merged 1 commit into from
Sep 3, 2023

Conversation

samsonasik
Copy link
Member

@TomasVotruba @staabm here to include VersionResolver::PACKAGE_VERSION value to be part of hash to ensure when run:

composer update

# got new version

# re-run rector got automatically cleared cache
vendor/bin/rector

@samsonasik
[Caching] Add VersionResolver::PACKAGE_VERSION to FileHashComputer::c…
93f5471 
…ompute() so cache cleared on composer update got new version
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik mentioned this pull request Sep 3, 2023
Merged
@TomasVotruba TomasVotruba merged commit e203bb4 into main Sep 3, 2023
@TomasVotruba TomasVotruba deleted the add-package-version branch September 3, 2023 22:38
@TomasVotruba
Copy link
Member

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba