Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostRector] Remove CurrentFileProvider on PostFileProcessor #5097

Merged
merged 3 commits into from
Oct 1, 2023
Merged

[PostRector] Remove CurrentFileProvider on PostFileProcessor #5097

merged 3 commits into from
Oct 1, 2023

Conversation

samsonasik
Copy link
Member

Directly pass file name from FileProcessor.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

This also reduce repetitive $file->getFilePath() 👍

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Looks good 👏

@TomasVotruba TomasVotruba merged commit 8adfc7a into main Oct 1, 2023
@TomasVotruba TomasVotruba deleted the post-file branch October 1, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba