New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance][Renaming] Use FullyQualified on RenameClassRector #5272

Merged

samsonasik merged 1 commit into main from rename-fully

Nov 22, 2023

Member

samsonasik commented Nov 22, 2023 •

edited

Loading

By this, we can remove unused attribute IS_NAMESPACE_NAME as it always a Name instead of `FullyQualified.

For renaming by namespace, it renamed from Namespace_ node on getNodeTypes() already.


          [Performance][Renaming] Use FullyQualified on RenameClassRector

d6862b6

samsonasik requested a review from TomasVotruba as a code owner

November 22, 2023 17:34

Member Author

samsonasik commented Nov 22, 2023

All checks have passed 🎉 @TomasVotruba I am merging it ;)

samsonasik merged commit fcd1b1a into main

samsonasik deleted the rename-fully branch

November 22, 2023 17:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet