Remove json throw on error rule from PHP 7.3 set, as changed behavior and must be applied on purpose #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-json-thror-error
branch
from
35a4682 to
bcd2b9a
Compare
… and must be applied on purpose
TomasVotruba
force-pushed
the
tv-json-thror-error
branch
from
bcd2b9a to
26b1344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule should be applied only on purpose in case of behavior changed is needed.
In practise this stop the seamless PHP 7.3 upgrade and rule has to be manually excluded.
Better alrenatives as nette/utils json class are also available, so this upgrade is optional.