Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance][PhpParser] Deprecate InlineCodeParser::parse(), extract into parseFile() and parseString() #5482

Merged
merged 5 commits into from
Jan 23, 2024
Merged

[Performance][PhpParser] Deprecate InlineCodeParser::parse(), extract into parseFile() and parseString() #5482

merged 5 commits into from
Jan 23, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 19, 2024 •
edited
Loading

Avoid unnecessary IO foris_file() when it actually just content, make consistent with other 3: SimplePhpParser and RectorParser, and SmartPhpParser which has 2 methods:

  • parseFile()
  • parseString()

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit f7caedf into main Jan 23, 2024
40 checks passed
@TomasVotruba TomasVotruba deleted the deprecated-inlinecode-parse branch January 23, 2024 09:38
@TomasVotruba
Copy link
Member

Thanks 👍

@samsonasik samsonasik mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba