-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Renaming] New Rule: RenameFunctionLikeParamWithinCallLikeArgRector #5554
Merged
TomasVotruba
merged 14 commits into
rectorphp:main
from
peterfox:feature/rename-param-for-function-like-within-call-like
Feb 22, 2024
Merged
[Renaming] New Rule: RenameFunctionLikeParamWithinCallLikeArgRector #5554
TomasVotruba
merged 14 commits into
rectorphp:main
from
peterfox:feature/rename-param-for-function-like-within-call-like
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-call-like # Conflicts: # build/target-repository/docs/rector_rules_overview.md
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Abdul Malik Ikhsan <[email protected]>
samsonasik
reviewed
Feb 18, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Feb 18, 2024
Thank you @samsonasik! |
@samsonasik I did some refactoring to clean up the rule by using some of the built-in services for detecting variable renaming. I wondered if you could have another look. |
samsonasik
reviewed
Feb 22, 2024
rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Abdul Malik Ikhsan <[email protected]>
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Similar to #5547 in that it can find a parameter to a FunctionLike structure supplied as an Arg to a MethodCall. Then it will rename the Param and apply that to any usage of the variable inside the FunctionLike.
with a example configuration of:
Notes
The renaming of the variable will only go as far as possible. If a further FunctionLike structure exists using that variable then it will ignore the rename of the variable.