[DeadCode] Skip sub type false => bool on RemoveUselessVarTagRector #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 🎉 /cc @kamil-tekiela |
samsonasik
commented
Feb 9, 2024
Comment on lines
90
to
92
| // normalize bool union types | ||
| $phpParserNodeType = $this->normalizeConstantBooleanType($phpParserNodeType); | ||
| $phpStanDocType = $this->normalizeConstantBooleanType($phpStanDocType); |
There was a problem hiding this comment.
this apparently, make the valid removal skipped for super type:
/** @var string|bool|null */
private static string|false|null $inputArgSeparator = null;
which docblok is super type, I will look more.
There was a problem hiding this comment.
I added failing test case for valid removal super type 0c89834
There was a problem hiding this comment.
Fixed with equal and sub type check 3690cad
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8475