Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.0] Add always class to AnnotationToAttribute to include string to ::class reference conversion #5619

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Feb 14, 2024

This way we can make sure the class references is used in places that expect it:

Before

#[\Doctrine\ORM\Mapping\Entity(repositoryClass: 'App\Some\SomeClass')]
class DoctrineEntity
{
}

After

#[\Doctrine\ORM\Mapping\Entity(repositoryClass: \App\Some\SomeClass::class)]
class DoctrineEntity
{
}

@TomasVotruba TomasVotruba force-pushed the tv-annotatin-to-attribute-always-class branch 2 times, most recently from 7fc033e to 9952ed5 Compare February 14, 2024 19:20
@TomasVotruba TomasVotruba changed the title tv annotatin to attribute always class [PHP 8.0] Add always class to AnnotationToAttribute to include string to ::class reference conversion Feb 14, 2024
@TomasVotruba TomasVotruba force-pushed the tv-annotatin-to-attribute-always-class branch from 9952ed5 to d3ed1c7 Compare February 14, 2024 19:25
@TomasVotruba TomasVotruba enabled auto-merge (squash) February 14, 2024 19:26
@TomasVotruba TomasVotruba merged commit 2ff0f08 into main Feb 14, 2024
41 checks passed
@TomasVotruba TomasVotruba deleted the tv-annotatin-to-attribute-always-class branch February 14, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant