[CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
|
just a drive-by thing which came to my mind: I think the rule should be skipped when a class has magic |
TomasVotruba
force-pushed
the
tv-dyna-rule
branch
2 times, most recently
from
43868ca to
386e517
Compare
TomasVotruba
force-pushed
the
tv-dyna-rule
branch
from
386e517 to
8962498
Compare
|
@staabm Makes sense, I'll skip those 👍 |
TomasVotruba
force-pushed
the
tv-dyna-rule
branch
from
1cc16de to
fa402af
Compare
samsonasik
reviewed
Oct 12, 2024
rules/CodeQuality/Rector/Class_/DynamicDocBlockPropertyToNativePropertyRector.php
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-dyna-rule
branch
from
fa402af to
c742d4b
Compare
TomasVotruba
force-pushed
the
tv-dyna-rule
branch
from
0ca5779 to
9a38c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.