[Performance] Call cached class names collection on FamilyRelationsAnalyzer #5879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfn @dorrogeray here continuation of PR:
to improve performance, to ensure call
$this->reflectionProvider->getClass()
on service that only use it, which isFamilyRelationsAnalyzer
, and asFamilyRelationsAnalyzer
is shared service, create a flag for it that it already cached.Before 58.689 seconds
After 37.014
Closes rectorphp/rector#8637
Closes rectorphp/rector#8638