[TypeDeclaration] Add TypedPropertyFromJMSSerializerAttributeTypeRector #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
samsonasik
commented
May 24, 2024
| #[\JMS\Serializer\Annotation\Type('string')] | ||
| private $name; | ||
|
|
||
| public function setName(string $name): void |
There was a problem hiding this comment.
assign typed already covered by other rule
https://getrector.com/demo/96ca5ad6-dd87-406e-88bf-6e073ed17e32
samsonasik
commented
May 24, 2024
| final class SkipWithDefault | ||
| { | ||
| #[\JMS\Serializer\Annotation\Type('string')] | ||
| private $name = 'foo'; |
There was a problem hiding this comment.
With default already covered by other rule https://getrector.com/demo/2479ea75-5faa-45b5-8b62-7738cc69d1ec
|
Looks great 👍 Thanks for skipping the cases covered by other rules, so we have indepedent rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#8652