New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeTypeResolver] Remove Property->type instanceof Node check on NodeTypeResolver->getType() #5947

Merged

samsonasik merged 1 commit into main from node-type-prop

Jun 6, 2024

Member

samsonasik commented Jun 6, 2024 •

edited

Loading

The check Property->type instanceof Node seems no longer needed
and avoid replace node into another node on Name with NAMESPACED_NAME attribute, use to getType() instead.


          [NodeTypeResolver] Remove Property->type instanceof Node check on Nod…

40f399c

…eTypeResolver->getType()

Member Author

samsonasik commented Jun 6, 2024

All checks have passed 🎉 @TomasVotruba I am merging it ;)

samsonasik merged commit e0442d7 into main

39 checks passed

samsonasik deleted the node-type-prop branch

June 6, 2024 10:51

TomasVotruba mentioned this pull request

Remove direct Name support from getType(), as name is never a type #6089

Merged

samsonasik mentioned this pull request

[NodeTypeResolver] Move namespaced name check into specific NameTypeResolver #6093

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet