[DX] Introduce set providers, to enable package + version based set registration #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
2 times, most recently
from
b7d2325 to
c0bc5ed
Compare
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
from
c0bc5ed to
d3e967f
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
4 times, most recently
from
6e0912d to
7bc1597
Compare
samsonasik
reviewed
Jun 20, 2024
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
4 times, most recently
from
34eb192 to
1704677
Compare
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
from
1704677 to
c1fd131
Compare
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
from
c1fd131 to
70fa2e0
Compare
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
from
ae8c1be to
4279d5a
Compare
TomasVotruba
force-pushed
the
tv-prepared-sets-twig-2
branch
from
abd1032 to
c48b4d3
Compare
|
Ready to go. Mergin to test in the rector-symfony package 👍 |
|
this feature is amazing why dont you write an article or a page in your site? |
|
Good point ☝️ I'll get to that next week |
TomasVotruba
referenced
this pull request
in rectorphp/rector-phpunit
Nov 12, 2024
This was referenced Nov 12, 2024
|
We're getting closer to finish :) I've improved the feature to take package version into an account: #6428 Post and documentation is ready on getrector.com repository as well rectorphp/getrector-com#2672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used https://github.com/rectorphp/rector-symfony/blob/main/src/Set/SetProvider/TwigSetProvider.php
See documentation rectorphp/getrector-com#2672