Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Remove ArrowFunction from ReturnTypeFromReturnDirectArrayRector and ReturnTypeFromReturnNewRector #6032

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

samsonasik
Copy link
Member

Part of resolve this issue effort:

Ref from PR comment:

For ArrowFunction, there is already rule that cover return type on ArrowFunction

  • AddArrowFunctionReturnTypeRector

so no need to duplicate process in the following rules:

  • ReturnTypeFromReturnDirectArrayRector
  • ReturnTypeFromReturnNewRector

…tArrayRector and ReturnTypeFromReturnNewRector
@samsonasik samsonasik changed the title [TypeDeclaration] Remove ArrowFunction from ReturnTypeFromReturnDirectArrayRector and ReturnTypeFromReturnNewRector [TypeDeclaration] Remove ArrowFunction type from ReturnTypeFromReturnDirectArrayRector and ReturnTypeFromReturnNewRector Jun 25, 2024
@samsonasik samsonasik changed the title [TypeDeclaration] Remove ArrowFunction type from ReturnTypeFromReturnDirectArrayRector and ReturnTypeFromReturnNewRector [TypeDeclaration] Remove ArrowFunction from ReturnTypeFromReturnDirectArrayRector and ReturnTypeFromReturnNewRector Jun 25, 2024
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit ae9baac into main Jun 26, 2024
35 checks passed
@TomasVotruba TomasVotruba deleted the remove-arrow branch June 26, 2024 02:46
@TomasVotruba
Copy link
Member

Thanks 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants