Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Add AddClosureNeverReturnTypeRector #6039

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[TypeDeclaration] Add AddClosureNeverReturnTypeRector #6039

merged 2 commits into from
Jun 26, 2024

Conversation

samsonasik
Copy link
Member

Part of resolve this issue effort:

Ref from PR comment:

this PR extract Closure from ReturnNeverTypeRector into separate new rule: AddClosureNeverReturnTypeRector special for Closure only.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit dbcc9cb into main Jun 26, 2024
35 checks passed
@TomasVotruba TomasVotruba deleted the add-never branch June 26, 2024 09:05
@TomasVotruba
Copy link
Member

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba