[Cleanup] Deprecate ChangeAndIfToEarlyReturnRector as creates less readable code with inverted conditions #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s readable code with inverted conditions
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-change-detection
branch
2 times, most recently
from
5afe681 to
48bb99d
Compare
TomasVotruba
force-pushed
the
tv-change-detection
branch
from
48bb99d to
4e01d3b
Compare
TomasVotruba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall making this rule at early years of Rector, to showcase what Rector can do. Looking at it now, it makes code quite hard to read and removes the original point of single line check.
The rest of early-return give code more readbility 👍 , so this one is an odd one :)
Time to deprecate.