Refactor BooleanTypeMapper to handle value based on context #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
2 times, most recently
from
e4dd789 to
8099863
Compare
|
Ready for review @samsonasik 👍 |
TomasVotruba
commented
Jul 1, 2024
samsonasik
reviewed
Jul 1, 2024
...-tests/TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/Fixture/multi_scalar.php.inc
Outdated
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
3 times, most recently
from
e84bde3 to
694d03c
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
from
694d03c to
780e6c7
Compare
|
Updated the title to reflect change better :) |
samsonasik
reviewed
Jul 1, 2024
...assPropertyAssignToConstructorPromotionRector/FixturePhp80/add_default_false_to_bool.php.inc
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
from
780e6c7 to
0ae4bf2
Compare
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
from
0ae4bf2 to
31969f6
Compare
samsonasik
reviewed
Jul 1, 2024
TomasVotruba
force-pushed
the
tv-narrow-generic-name-4
branch
from
97b0359 to
f726df5
Compare
samsonasik
approved these changes
Jul 1, 2024
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.