Check root return in ReturnTypeFromReturnNewRector #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-split-nullable-and-return
branch
from
08a6b21 to
541ceeb
Compare
samsonasik
reviewed
Jul 2, 2024
...assMethod/ReturnTypeFromReturnNewRector/Fixture/skip_possible_void_with_early_return.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
Jul 2, 2024
| return new FirstResponse(); | ||
| } | ||
|
|
||
| return new SecondResponse(); |
There was a problem hiding this comment.
new fixture for else syntax seems needed:
if (mt_rand(0, 1)) {
return new FirstResponse();
} else {
return new SecondResponse();
}SilentVoidResolver->hasSilentVoid($node) should can detect that, if you want to consider...
There was a problem hiding this comment.
I'll look into it in next iteration
There was a problem hiding this comment.
I already create new PR for that:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.