Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php52] Handle deep if stmts on ContinueToBreakInSwitchRector #6122

Merged
merged 3 commits into from
Jul 5, 2024
Merged

[Php52] Handle deep if stmts on ContinueToBreakInSwitchRector #6122

merged 3 commits into from
Jul 5, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @itsdanielfelix

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 8f81fe9 into main Jul 5, 2024
33 checks passed
@samsonasik samsonasik deleted the dep-if branch July 5, 2024 20:28
@samsonasik
Copy link
Member Author

samsonasik commented Jul 6, 2024 •
edited
Loading

inside else seems need to be handled

https://getrector.com/demo/45931bc4-1022-42a6-bf7e-0106252c0c54

to cover it, the way check Else_, ElseIf, etc

I will look into it.

@samsonasik samsonasik mentioned this pull request Jul 6, 2024
Merged
@samsonasik
Copy link
Member Author

#6123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @actions-user