Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Add AddParamArrayDocblockBasedOnCallableNativeFuncCallRector #6233

Merged
merged 27 commits into from
Aug 14, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 13, 2024

@samsonasik samsonasik marked this pull request as draft August 13, 2024 09:59
@samsonasik samsonasik marked this pull request as ready for review August 14, 2024 13:24
@samsonasik
Copy link
Member Author

implemented 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

TomasVotruba commented Aug 14, 2024

Looks great... based on your feedback on my rule, I can see you really dig into edge-cases 👏
Let's ship it 🥳

@TomasVotruba TomasVotruba merged commit fdd7f63 into main Aug 14, 2024
35 checks passed
@TomasVotruba TomasVotruba deleted the add-param-array-doc branch August 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[type-declarations] New rule to fill param array based on param traverse callbacks
3 participants