Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated register ContinueToBreakInSwitchRector in php52.php and php73.php #6385

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 16, 2024

it exists in php52.php and php73.php

$rectorConfig->rules([VarToPublicPropertyRector::class, ContinueToBreakInSwitchRector::class]);

ContinueToBreakInSwitchRector::class,

detected when create experiment PR:

On PHP_INT_MAX level, it show error:

cd e2e/with-php-level && composer install
with-php-level git:(experiment-use-composer-json-priority-fallback) ✗ php ../e2eTestRunner.php
    ---------- begin diff ----------
@@ @@
-[ERROR] Following rules are registered twice: Rector\Php52\Rector\Switch_\ContinueToBreakInSwitchRector

when using

->withPhpLevel(PHP_INT_MAX)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit cdeea08 into main Oct 16, 2024
36 checks passed
@samsonasik samsonasik deleted the fix-duplicate-register branch October 16, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant