Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add DocumentedAbstractRector #6560

Closed
wants to merge 7 commits into from
Closed

[Core] Add DocumentedAbstractRector #6560

wants to merge 7 commits into from

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 11, 2024 •
edited
Loading

based on @GeniJaho feedback at #6477 (comment)

this add DocumentedAbstractRector to allow community to implements DocumentedRuleInterface by extending DocumentedAbstractRector to allow generate docs.

@samsonasik samsonasik mentioned this pull request Dec 11, 2024
Merged
@samsonasik
Copy link
Member Author

All checks have passed @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

samsonasik commented Dec 11, 2024 •
edited
Loading

The class name can be changed to DocumentedAbstractRector or something similar if needed.

@samsonasik samsonasik changed the title [Core] Add CommunityAbstractRector [Core] Add DocumentedAbstractRector Dec 11, 2024
@samsonasik
Copy link
Member Author

I renamed to DocumentedAbstractRector for more clarify of usage

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 11, 2024 •
edited
Loading

I'll handle the issue 👌

@samsonasik samsonasik deleted the add-community-abstract-rector branch December 11, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba