fix: replace getKey/getValue methods when enum is a variable #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 14, 2024
...hp81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/usage_of_get_value.php.inc
Show resolved
Hide resolved
carlosvinicius
force-pushed
the
fix/myclabs-enum-method-calls-in-variables
branch
4 times, most recently
from
e4b99e2 to
a15874d
Compare
samsonasik
reviewed
Dec 14, 2024
...1/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/skip_usage_of_get_key.php.inc
Outdated
Show resolved
Hide resolved
carlosvinicius
force-pushed
the
fix/myclabs-enum-method-calls-in-variables
branch
from
a15874d to
75f31c2
Compare
samsonasik
approved these changes
Dec 14, 2024
|
Thank you @carlosvinicius , let's give it a try 👍 /cc @OskarStark if you have a chance, please try latest dev-main a try, ensure there is no regression for this change and previous @carlosvinicius PR: as seems you were using it on other issue: thank you. |
|
Hi, I moved away from this lab, as all my projects are using native enums now. Thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current My C-Labs rule only replaces the methods
getKeyandgetValueif they are called from an enum case. It is currently skipping when an enum is previously assigned to a variable. This PR fixes this missing case.