[CodeQuality] FuncLikeToFirstClassCallableRector #6667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FuncLikeToFirstClassCallableRector
ruleWhy
This reduces the user of Closures and Arrow functions where they are basically redundant and code be replaced by a First-Class Callable instead of being wrapped in a closure.
Notes
I debated what group this should be in. It could be considered Code Quality but equally it could be Deadcode or even Code Style. I'm happy to change it based on feedback.
Risk
There might be some risk for this if used with closure binding e.g.
Might end up as
If that's a problem then I can make the rule avoid method calls of
$this
.