[CodingStyle] Handle ClassConstFetch on RemoveUnusedAliasRector #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
|
/cc @DieterHolvoet for the change of behaviour. |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #784 , I think ClassConstFetch should be removed too if there is no conflict with use alias, it only make sense to have alias only if has conflict name in use statement.
Ref for original issue: rectorphp/rector#5687
Ref for original PR that introduce it: rectorphp/rector#5691
ref https://3v4l.org/H4lrmT for demo that it actually same to use alias or not.