[DowngradeSymfony70] Add DowngradeSymfonyCommandAttributeRector

config/sets/symfony/configs.php

@@ -7,7 +7,6 @@
 use Rector\Symfony\Configs\Rector\Closure\ServiceSetStringNameToClassNameRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceSettersToSettersAutodiscoveryRector;
 use Rector\Symfony\Configs\Rector\Closure\ServicesSetNameToSetTypeRector;
-
 use Rector\Symfony\Configs\Rector\Closure\ServiceTagsToDefaultsAutoconfigureRector;
 
 return static function (RectorConfig $rectorConfig): void {

config/sets/symfony/symfony31.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector;
-
 use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\Config\RectorConfig;
 

config/sets/symfony/symfony33.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-
 use Rector\Arguments\ValueObject\ArgumentAdder;
 use Rector\Config\RectorConfig;
 use Rector\Renaming\Rector\MethodCall\RenameMethodRector;

config/sets/symfony/symfony42.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use PHPStan\Type\IterableType;
-
 use PHPStan\Type\MixedType;
 use Rector\Arguments\NodeAnalyzer\ArgumentAddingScope;
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;

config/sets/symfony/symfony51.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use PHPStan\Type\ObjectType;
-
 # https://github.com/symfony/symfony/blob/5.x/UPGRADE-5.1.md
 use Rector\Config\RectorConfig;
 use Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector;

phpstan.neon

@@ -51,3 +51,8 @@ parameters:
         - '#Cognitive complexity for "Rector\\Symfony\\CodeQuality\\Rector\\Closure\\StringExtensionToConfigBuilderRector\:\:create(.*?)\(\)" is 13, keep it under 10#'
 
         - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
+
+        -
+            message: '#Cognitive complexity for "Rector\\Symfony\\DowngradeSymfony70\\Rector\\Class_\\DowngradeSymfonyCommandAttributeRector\:\:(resolveNameAndDescription|refactor)\(\)" is 13|15, keep it under 10#'
+            path: rules/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector.php
+

rules-tests/CodeQuality/Rector/MethodCall/AssertSameResponseCodeWithDebugContentsRector/config/configured_rule.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-
 use Rector\Symfony\CodeQuality\Rector\MethodCall\AssertSameResponseCodeWithDebugContentsRector;
 
 return static function (RectorConfig $rectorConfig): void {

rules-tests/Configs/Rector/ClassMethod/AddRouteAnnotationRector/config/configured_rule.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-
 use Rector\Symfony\Bridge\Symfony\Routing\SymfonyRoutesProvider;
 use Rector\Symfony\Configs\Rector\ClassMethod\AddRouteAnnotationRector;
 use Rector\Symfony\Contract\Bridge\Symfony\Routing\SymfonyRoutesProviderInterface;

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/DowngradeSymfonyCommandAttributeRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DowngradeSymfonyCommandAttributeRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/Fixture/skip_not_extends_command.php.inc

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+class SkipNotExtendsCommand
+{
+}

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/Fixture/skip_set_in_configure.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+
+class SkipSetInConfigure extends Command
+{
+    protected function configure(): void
+    {
+        $this->setName('app:create-user');
+    }
+}

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/Fixture/with_existing_configure_method.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+#[AsCommand(name: 'app:create-user')]
+class WithExistingConfigureMethod extends Command
+{
+    protected function configure()
+    {
+        echo 'test';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+class WithExistingConfigureMethod extends Command
+{
+    protected function configure()
+    {
+        echo 'test';
+        $this->setName('app:create-user');
+    }
+}
+
+?>

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/Fixture/with_name.php.inc

@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+#[AsCommand(name: 'app:create-user')]
+class WithName extends Command
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+class WithName extends Command
+{
+    protected function configure()
+    {
+        $this->setName('app:create-user');
+    }
+}
+
+?>

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/Fixture/with_name_and_description.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+#[AsCommand(name: 'app:create-user', description: 'some description')]
+class WithNameAndDescription extends Command
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+class WithNameAndDescription extends Command
+{
+    protected function configure()
+    {
+        $this->setName('app:create-user');
+        $this->setDescription('some description');
+    }
+}
+
+?>

rules-tests/DowngradeSymfony70/Rector/Class_/DowngradeSymfonyCommandAttributeRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(DowngradeSymfonyCommandAttributeRector::class);
+};

rules-tests/Symfony34/Rector/Closure/ContainerGetNameToTypeInTestsRector/config/configured_rule.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-
 use Rector\Symfony\Symfony34\Rector\Closure\ContainerGetNameToTypeInTestsRector;
 
 return static function (RectorConfig $rectorConfig): void {

rules-tests/Symfony43/Rector/StmtsAwareInterface/TwigBundleFilesystemLoaderToTwigRector/config/configured_rule.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-
 use Rector\Symfony\Symfony43\Rector\StmtsAwareInterface\TwigBundleFilesystemLoaderToTwigRector;
 
 return static function (RectorConfig $rectorConfig): void {

rules-tests/Symfony60/Rector/FuncCall/ReplaceServiceArgumentRector/config/configured_rule.php

@@ -3,9 +3,7 @@
 declare(strict_types=1);
 
 use PhpParser\Node\Scalar\String_;
-
 use Psr\Container\ContainerInterface;
-
 use Rector\Config\RectorConfig;
 use Rector\Symfony\Symfony60\Rector\FuncCall\ReplaceServiceArgumentRector;
 use Rector\Symfony\ValueObject\ReplaceServiceArgument;

rules/Configs/Rector/Closure/ServicesSetNameToSetTypeRector.php

@@ -29,7 +29,7 @@ final class ServicesSetNameToSetTypeRector extends AbstractRector
      */
     private array $alreadyChangedServiceNamesToTypes = [];
 
-    private bool  $hasChanged = false;
+    private bool $hasChanged = false;
 
     /**
      * @var array<string, string[]>