[CodingStyle] Fixes #5687 Skip RemoveUnusedAliasRector on used in Cla…

…ssConstFetch
rectorphp · Feb 26, 2021 · 617994d · 617994d
1 parent 38e8520
commit 617994d
Showing 1 changed file with 24 additions and 4 deletions.
diff --git a/rules/coding-style/src/Rector/Use_/RemoveUnusedAliasRector.php b/rules/coding-style/src/Rector/Use_/RemoveUnusedAliasRector.php
@@ -5,8 +5,8 @@
 namespace Rector\CodingStyle\Rector\Use_;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Name;
-use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Use_;
 use PhpParser\Node\Stmt\UseUse;
 use Rector\CodingStyle\Naming\NameRenamer;
@@ -140,7 +140,7 @@ public function refactor(Node $node): ?Node
 
             /** @var string $aliasName */
             $aliasName = $this->getName($use->alias);
-            if ($this->shouldSkip($lastName, $aliasName)) {
+            if ($this->shouldSkip($node, $use->name, $lastName, $aliasName)) {
                 continue;
             }
 
@@ -188,7 +188,7 @@ private function lowercaseArray(array $values): array
         }, $values);
     }
 
-    private function shouldSkip(string $lastName, string $aliasName): bool
+    private function shouldSkip(Use_ $use, Name $name, string $lastName, string $aliasName): bool
     {
         // PHP is case insensitive
         $loweredLastName = strtolower($lastName);
@@ -200,7 +200,27 @@ private function shouldSkip(string $lastName, string $aliasName): bool
         }
 
         // part of some @Doc annotation
-        return in_array($loweredAliasName, $this->resolvedDocPossibleAliases, true);
+        if (in_array($loweredAliasName, $this->resolvedDocPossibleAliases, true)) {
+            return true;
+        }
+
+        $isFoundNext = (bool) $this->betterNodeFinder->findFirstNext($use, function (Node $node) use ($name): bool {
+            if (! $node instanceof ClassConstFetch) {
+                return false;
+            }
+
+            if (! $node->class instanceof Name) {
+                return false;
+            }
+
+            return $node->class->toString() === $name->toString();
+        });
+
+        if ($isFoundNext) {
+            return true;
+        }
+
+        return false;
     }
 
     private function refactorAliasName(string $aliasName, string $lastName, UseUse $useUse): void