-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG missing level 2 headings for versions since 0.8.29 (October 2020) #5666
Comments
Yes, duplicate with #5663 |
@samsonasik could we re open this one? as #5663 didn't fix the issue described in the title? |
for latest heading tag, it may need wait for next release. I am not sure if old releases will re-generated or requires manual check, @TomasVotruba what do you think? |
@samsonasik The changelog linker output should generated old tags too, so deleting the file and generating again should help |
@TomasVotruba thank you. I think it is close-able in next relase then? |
The release does not depend on changelog linker. You can regenerate the file now too |
I tried remove CHANGELOG.md and re-create it, then run: > vendor/bin/changelog-linker dump-merges --ansi
In SmartFileSystem.php line 30:
Failed to read "/Users/samsonasik/www/rector/CHANGELOG.md" file: "Since symfony/dependency-injection 5.1: The "Symfony\Component\DependencyInjection\ContainerInterface" autowiring alias is deprecated
. Define it explicitly in your app if you want to keep using it. It is being referenced by the "Symplify\PackageBuilder\Parameter\ParameterProvider" service."
dump-merges [--in-categories] [--in-packages] [--dry-run] [--since-id SINCE-ID] [--base-branch [BASE-BRANCH]] [-c|--config CONFIG]
Script vendor/bin/changelog-linker dump-merges --ansi handling the changelog event returned with error code 1 Is there something missing? |
It's probably needs an empty file. |
I use empty file, previously, when no file exits yet, it got different error: composer changelog
> vendor/bin/changelog-linker dump-merges --ansi
In FileSystemGuard.php line 17:
File "/Users/samsonasik/www/rector/CHANGELOG.md" not found in "Symplify\ChangelogLinker\FileSystem\ChangelogFileSystem::readChangelog".
dump-merges [--in-categories] [--in-packages] [--dry-run] [--since-id SINCE-ID] [--base-branch [BASE-BRANCH]] [-c|--config CONFIG]
Script vendor/bin/changelog-linker dump-merges --ansi handling the changelog event returned with error code 1 |
Maybe new file could be created in this case instead. Could you handle it in Symplify? |
I will try. |
We won't be using CHANGELOG anymore, see deprecated-packages/symplify#3027 for explanation |
rectorphp/rector-src@a56ee1e [DeadCode] Fix infinite loop on RemoveDeadStmtRector + RemoveUnusedVariableAssignRector (#5666)
The last CHANGELOG level 2 heading is
## [0.8.29] - 2020-10-16
~60 releases has happened since this point but the CHANGELOG doesn't contain the correct headings for these.
Instead the document mainly consists of level 3 headings with no separations.
https://github.com/rectorphp/rector/blob/master/CHANGELOG.md
The text was updated successfully, but these errors were encountered: