Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG missing level 2 headings for versions since 0.8.29 (October 2020) #5666

Closed
addshore opened this issue Feb 23, 2021 · 12 comments
Closed
Labels

Comments

@addshore
Copy link
Contributor

addshore commented Feb 23, 2021

The last CHANGELOG level 2 heading is ## [0.8.29] - 2020-10-16
~60 releases has happened since this point but the CHANGELOG doesn't contain the correct headings for these.
Instead the document mainly consists of level 3 headings with no separations.

https://github.com/rectorphp/rector/blob/master/CHANGELOG.md

@addshore addshore added the bug label Feb 23, 2021
@samsonasik
Copy link
Member

Yes, duplicate with #5663

@addshore
Copy link
Contributor Author

@samsonasik could we re open this one? as #5663 didn't fix the issue described in the title?
Unless we don't want the existing changelog fixed

@samsonasik
Copy link
Member

for latest heading tag, it may need wait for next release. I am not sure if old releases will re-generated or requires manual check, @TomasVotruba what do you think?

@samsonasik samsonasik reopened this Feb 27, 2021
@TomasVotruba
Copy link
Member

@samsonasik The changelog linker output should generated old tags too, so deleting the file and generating again should help

@samsonasik
Copy link
Member

@TomasVotruba thank you. I think it is close-able in next relase then?

@TomasVotruba
Copy link
Member

TomasVotruba commented Feb 28, 2021

The release does not depend on changelog linker. You can regenerate the file now too

@samsonasik
Copy link
Member

I tried remove CHANGELOG.md and re-create it, then run: composer changelog got the following output:

Screen Shot 2021-02-28 at 14 53 54

> vendor/bin/changelog-linker dump-merges --ansi

In SmartFileSystem.php line 30:
                                                                                                                                                                                                           
  Failed to read "/Users/samsonasik/www/rector/CHANGELOG.md" file: "Since symfony/dependency-injection 5.1: The "Symfony\Component\DependencyInjection\ContainerInterface" autowiring alias is deprecated  
  . Define it explicitly in your app if you want to keep using it. It is being referenced by the "Symplify\PackageBuilder\Parameter\ParameterProvider" service."                                           
                                                                                                                                                                                                           

dump-merges [--in-categories] [--in-packages] [--dry-run] [--since-id SINCE-ID] [--base-branch [BASE-BRANCH]] [-c|--config CONFIG]

Script vendor/bin/changelog-linker dump-merges --ansi handling the changelog event returned with error code 1

Is there something missing?

@TomasVotruba
Copy link
Member

It's probably needs an empty file.

@samsonasik
Copy link
Member

I use empty file, previously, when no file exits yet, it got different error:

composer changelog
> vendor/bin/changelog-linker dump-merges --ansi

In FileSystemGuard.php line 17:
                                                                                                                                           
  File "/Users/samsonasik/www/rector/CHANGELOG.md" not found in "Symplify\ChangelogLinker\FileSystem\ChangelogFileSystem::readChangelog".  
                                                                                                                                           

dump-merges [--in-categories] [--in-packages] [--dry-run] [--since-id SINCE-ID] [--base-branch [BASE-BRANCH]] [-c|--config CONFIG]

Script vendor/bin/changelog-linker dump-merges --ansi handling the changelog event returned with error code 1

@TomasVotruba
Copy link
Member

Maybe new file could be created in this case instead. Could you handle it in Symplify?

@samsonasik
Copy link
Member

I will try.

@TomasVotruba
Copy link
Member

We won't be using CHANGELOG anymore, see deprecated-packages/symplify#3027 for explanation

TomasVotruba added a commit that referenced this issue Feb 27, 2024
rectorphp/rector-src@a56ee1e [DeadCode] Fix infinite loop on RemoveDeadStmtRector + RemoveUnusedVariableAssignRector (#5666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants