Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Add RevRec settings to business entities #817

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[V2] Add RevRec settings to business entities #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Library/BusinessEntity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ public class BusinessEntity : RecurlyEntity
public TaxAddress TaxAddress { get; set; }
public string DefaultVatNumber { get; set; }
public string DefaultRegistrationNumber { get; set; }
public string DefaultLiabilityGlAccountId { get; private set; }
public string DefaultRevenueGlAccountId { get; private set; }
public DateTime? CreatedAt { get; private set; }
public DateTime? UpdatedAt { get; private set; }

Expand Down Expand Up @@ -88,6 +90,12 @@ internal override void ReadXml(XmlTextReader reader)
case "default_registration_number":
DefaultRegistrationNumber = reader.ReadElementContentAsString();
break;
case "default_liability_gl_account_id":
DefaultLiabilityGlAccountId = reader.ReadElementContentAsString();
break;
case "default_revenue_gl_account_id":
DefaultRevenueGlAccountId = reader.ReadElementContentAsString();
break;
case "created_at":
CreatedAt = reader.ReadElementContentAsDateTime();
break;
Expand Down
20 changes: 17 additions & 3 deletions Test/BusinessEntityTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
using System;
using System.Collections.Generic;
using System.Xml;
using FluentAssertions;
using Xunit;

using Recurly.Test.Fixtures;


namespace Recurly.Test
{
Expand All @@ -18,5 +19,18 @@ public void LookupBusinessEntity()
businessEntity.TaxAddress.Country.Should().Be("US");
businessEntity.GetInvoices().Should().BeOfType<InvoiceList>();
}

[RecurlyFact(TestEnvironment.Type.Unit)]
public void CheckForRevRecData()
{
var businessEntity = new BusinessEntity();

var xmlFixture = FixtureImporter.Get(FixtureType.BusinessEntities, "show-200").Xml;
XmlTextReader reader = new XmlTextReader(new System.IO.StringReader(xmlFixture));
businessEntity.ReadXml(reader);

businessEntity.DefaultLiabilityGlAccountId.Should().Be("twrbsq39zvo5");
businessEntity.DefaultRevenueGlAccountId.Should().Be("bwrks63lznoi");
}
}
}
3 changes: 3 additions & 0 deletions Test/Fixtures/FixtureImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public static FixtureResponse Get(FixtureType type, string name)
throw new InvalidEnumArgumentException("type", (int)type, typeof(FixtureType));

var fixturePath = string.Format("Fixtures/{0}/{1}.xml", GetFixtureTypeDescription(type), name);
Console.WriteLine("Loading fixture for test: {0}", fixturePath);

if (!File.Exists(fixturePath))
throw new FileNotFoundException("Could not locate the fixture response file!", fixturePath);
Expand Down Expand Up @@ -76,6 +77,8 @@ private static KeyValuePair<string, string> ParseHeader(string line)
public enum FixtureType
{
Accounts,
[Description("business_entities")]
BusinessEntities,
[Description("external_payment_phases")]
ExternalPaymentPhases,
[Description("external_invoices")]
Expand Down
36 changes: 36 additions & 0 deletions Test/Fixtures/business_entities/show-200.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
HTTP/1.1 200 OK
Content-Type: application/xml; charset=utf-8

<?xml version="1.0" encoding="UTF-8"?>
<business_entity href="https://api.recurly.com/v2/business_entities/ske68up0zvae">
<invoices href="https://api.recurly.com/v2/business_entities/ske68up0zvae/invoices"/>
<id>ske68up0zvae</id>
<code>default</code>
<name>My Company, LLC</name>
<invoice_display_address>
<address1>1 Main</address1>
<address2></address2>
<city>San Jose</city>
<state>CA</state>
<zip>95120</zip>
<country>US</country>
<phone>317-555-6666</phone>
</invoice_display_address>
<tax_address>
<address1>1 Main</address1>
<address2></address2>
<city>San Jose</city>
<state>CA</state>
<zip>95120</zip>
<country>US</country>
<phone>317-555-6666</phone>
</tax_address>
<subscriber_location_countries type="array">
</subscriber_location_countries>
<default_vat_number></default_vat_number>
<default_registration_number></default_registration_number>
<created_at type="datetime">2023-03-16T18:29:52Z</created_at>
<updated_at type="datetime">2024-01-31T18:59:45Z</updated_at>
<default_liability_gl_account_id>twrbsq39zvo5</default_liability_gl_account_id>
<default_revenue_gl_account_id>bwrks63lznoi</default_revenue_gl_account_id>
</business_entity>
3 changes: 3 additions & 0 deletions Test/Recurly.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@
<Content Include="Fixtures\billinginfo\show-200.xml">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
<Content Include="Fixtures\business_entities\show-200.xml">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
<Content Include="Fixtures\client\gateway-unavailable-502.xml">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
Expand Down
Loading