-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support in creation of bucket class with mcg cli and a new test case for creation of rgw namespacestore using mcg-cli #11119
Conversation
…t case for creation of rgw namespace using mcg-cli Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
…ucketclass_over_backingspacestores and cli_create_bucketclass_over_namespacestores Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ypersky1980 , Just for safer side, please validate there is no need to change any code or change is required on below mentioned line
ocs-ci/ocs_ci/ocs/resources/bucketclass.py
Line 146 in 628f60b
# TODO: Implement support for Single-tiered NS bucketclass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@udaysk23 Thank you for noticiting, this comment is obsolete now, removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out, @udaysk23 . This line now is obsolete, removed it.
For validation and per @sagihirshfeld request I've run test_write_io_to_bucket.py test. test_write_io_to_bucket.py : 16/16 test cases have passed. The test run log is available here: rhsqe-repo.lab.eng.blr.redhat.com:/var/www/html/OCS/ypersky/ |
Signed-off-by: Yulia Persky <[email protected]>
01707db
For validation and per @sagihirshfeld request I've run test_write_io_to_bucket.py test. test_write_io_to_bucket.py : 16/16 test cases have passed. I've also run test_namespace_crd.py test. The test run log is available here: rhsqe-repo.lab.eng.blr.redhat.com:/var/www/html/OCS/ypersky/ypersky-vm1_test_namespace_crd_all_test_cases1.txt |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keesturam, sagihirshfeld, udaysk23, ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implements the following enhancement to cli_create_bucketclass method : in the past it was creating only backingstore with mcg-cli and from now on it will be able to create a bucketclass with mcg-cli command also for namespacestore.
Following this enhancement it was possible to add a new test case which implements creation of namespacestore and bucketclass for rgw using mcg-cli commands.
In the next PR I will implement automation of https://issues.redhat.com/browse/DFBUGS-1035 ( creating namespacestore and bucketclass on rgw bucket and writing IO to this bucket).