Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support in creation of bucket class with mcg cli and a new test case for creation of rgw namespacestore using mcg-cli #11119

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

ypersky1980
Copy link
Contributor

This PR implements the following enhancement to cli_create_bucketclass method : in the past it was creating only backingstore with mcg-cli and from now on it will be able to create a bucketclass with mcg-cli command also for namespacestore.

Following this enhancement it was possible to add a new test case which implements creation of namespacestore and bucketclass for rgw using mcg-cli commands.

In the next PR I will implement automation of https://issues.redhat.com/browse/DFBUGS-1035 ( creating namespacestore and bucketclass on rgw bucket and writing IO to this bucket).

…t case for creation of rgw namespace using mcg-cli

Signed-off-by: Yulia Persky <[email protected]>
@ypersky1980 ypersky1980 requested review from a team as code owners January 7, 2025 13:19
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jan 7, 2025
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
…ucketclass_over_backingspacestores and cli_create_bucketclass_over_namespacestores

Signed-off-by: Yulia Persky <[email protected]>
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ypersky1980 , Just for safer side, please validate there is no need to change any code or change is required on below mentioned line

# TODO: Implement support for Single-tiered NS bucketclass

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@udaysk23 Thank you for noticiting, this comment is obsolete now, removed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out, @udaysk23 . This line now is obsolete, removed it.

@ypersky1980
Copy link
Contributor Author

For validation and per @sagihirshfeld request I've run test_write_io_to_bucket.py test.

test_write_io_to_bucket.py : 16/16 test cases have passed.

The test run log is available here: rhsqe-repo.lab.eng.blr.redhat.com:/var/www/html/OCS/ypersky/

udaysk23
udaysk23 previously approved these changes Jan 13, 2025
sagihirshfeld
sagihirshfeld previously approved these changes Jan 13, 2025
Signed-off-by: Yulia Persky <[email protected]>
@ypersky1980 ypersky1980 dismissed stale reviews from sagihirshfeld and udaysk23 via 01707db January 13, 2025 21:31
@openshift-ci openshift-ci bot removed the lgtm label Jan 13, 2025
@ypersky1980
Copy link
Contributor Author

For validation and per @sagihirshfeld request I've run test_write_io_to_bucket.py test.

test_write_io_to_bucket.py : 16/16 test cases have passed.
The test run log is available here: rhsqe-repo.lab.eng.blr.redhat.com:/var/www/html/OCS/ypersky/shirshfe_test_write_io_to_bucket.txt

I've also run test_namespace_crd.py test.
test_namespace_crd.py : 25/25 test cases have passed.

The test run log is available here: rhsqe-repo.lab.eng.blr.redhat.com:/var/www/html/OCS/ypersky/ypersky-vm1_test_namespace_crd_all_test_cases1.txt

@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Jan 13, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 14, 2025
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit cc9eee2 into master Jan 16, 2025
6 of 7 checks passed
@ypersky1980 ypersky1980 deleted the ypersky_create_namespacestore_rgw_bucket branch January 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants