Add S3 navigation skeleton #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SanjalKatiyar
commented
Jan 28, 2025
SanjalKatiyar
commented
alfonsomthd
reviewed
Jan 28, 2025
alfonsomthd
reviewed
Jan 28, 2025
alfonsomthd
reviewed
Jan 28, 2025
|
LGTM. @bipuladh @GowthamShanmugam to tag. |
| [t] | ||
| ); | ||
|
|
||
| return <Tabs id="s3-permissions-tab" tabs={pages} basePath="permissions" />; |
There was a problem hiding this comment.
is "permissions" can be a constant? because any changes in this should also reflect in BucketOverview.tsx
There was a problem hiding this comment.
ack... this is just an initial PR... I will fix it later...
|
/test odf-console-e2e-aws |
|
LGTM cc: @alfonsomthd for tagging |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3b0dcac
into
red-hat-storage:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.