Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 middleware injection #637

Merged
merged 5 commits into from
Dec 27, 2023
Merged

V2 middleware injection #637

merged 5 commits into from
Dec 27, 2023

Conversation

redloaf
Copy link
Contributor

@redloaf redloaf commented Dec 21, 2023

💸 TL;DR

Adds hooks for overriding tracing middleware.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo

@redloaf redloaf requested a review from a team as a code owner December 21, 2023 20:13
@redloaf redloaf requested review from fishy, kylelemons and konradreiche and removed request for a team December 21, 2023 20:13
kylelemons
kylelemons approved these changes Dec 21, 2023
View reviewed changes
httpbp/middlewares.go Outdated Show resolved Hide resolved
internalv2compat/compat.go Show resolved Hide resolved
@redloaf redloaf merged commit 14f519d into master Dec 27, 2023
2 checks passed
@redloaf redloaf deleted the v2-middleware-injection branch December 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradreiche konradreiche konradreiche approved these changes

@kylelemons kylelemons kylelemons approved these changes

@fishy fishy fishy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redloaf @fishy @kylelemons @konradreiche