thriftbp: Support unix domain socket on thrift clients #649
Conversation
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
thriftbp/thrifttest/server.go
Outdated
| dir := cfg.TB.TempDir() | ||
| path := filepath.Join(dir, "socket") | ||
| socket = thrift.NewTServerSocketFromAddrTimeout(&net.UnixAddr{ | ||
| Net: "unix", | ||
| Name: path, | ||
| }, 0) | ||
| addr = "uds://" + path |
There was a problem hiding this comment.
I think this code will likely fail if ran on windows, but I don't think we care about windows users 🤷
if we do care about them, then we can extract this into 2 files with build conditions.
fishy
changed the title
There was a problem hiding this comment.
Out of curiosity, what is the reason to prefer unix domain sockets over tcp for testing? I've always preferred TCP when that's what will be used in real code; the two are very similar but do not behave identically and the underlying libraries may even have different explicit behaviors.
I don't have a strong opinion here of course.
I think make the test as close to real production as possible makes sense. Reverted that part of the changes. |
Also update thrifttest to use UDS when possible.