thriftbp: Fix a bug caused by bad merge from the previous PR #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bad merge between the previous 2 PRs, we are not really using the countingDelegateTransport in the client created by client pool, so the bytes are not counting and we always report 0 as the bytes read/written. Rename the args inside newClient generator to fix the bug.
fishy
requested review from
kylelemons,
konradreiche and
mathyourlife-reddit
and removed request for
a team
fishy
commented
May 7, 2024
Comment on lines
593
to
594
| protoFactory.GetProtocol(transport), | ||
| protoFactory.GetProtocol(transport), |
There was a problem hiding this comment.
the alternative fix is to use cdt over transport in these 2 lines, but I think renaming transport to raw and cdt to transport makes the code much clearer.
mathyourlife-reddit
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bad merge between the previous 2 PRs, we are not really using the countingDelegateTransport in the client created by client pool, so the bytes are not counting and we always report 0 as the bytes read/written.
Rename the args inside newClient generator to fix the bug.